Pull request aimed at fixing to runs 14210 and 14232 w/ weird phase offsets #1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgignac
approved these changes
Apr 28, 2025
sarahgaiser
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added two test files and the necessary lines to rawtrackerhitfitterdriver to read them in for these two runs. This should be all you need. Fit histograms from where the shifts were obtained are here: https://s3df.slac.stanford.edu/people/rodwyer1/phaseoffset/plots.html. You'll notice the shifts are a bit different in the text files; that because in each row I had to add together the original shift that was used (from 14495 I think is the run in the filename? Not sure as I write this) with what was found (because presumably the curves I fit were using the original shift).