lcsim 4.5.0 plus fixtrackstates #1115

baltzell · 2025-07-01T00:39:03Z

This is #1101 plus #1114.

…ane intercept; start to use this in TrackStates

* add dependabot.yml * fix oops * comments not allowed * bugfix * cleanup

Copilot

Pull Request Overview

This PR updates the lcsim dependency to 4.5.0, introduces an option to pivot track states at their plane intercept, and refactors Kalman interface methods for configurable pivot handling.

Upgrade lcsim version and add GitHub Maven repository
Add pivotAtIntercept flag through propagation and track-state creation
Clean up and extend Kalman/HPS bridging methods (e.g., new covariance extractor, coordinate transforms)

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
tracking/.../PropagatedTrackState.java	Pass new `pivotAtIntercept` flag into `toTrackState` call
tracking/.../KalmanInterface.java	Add `pivotAtIntercept` parameter, reorganize `toHPShelix`/`toTrackState`, new helpers
tracking/.../KalTrack.java	Implement `getHelixAtPlane(...)` with RK propagation
tracking/.../HelixState.java	Overload RK propagation to accept `pivotAtIntersect`
tracking/.../KFOutputDriver.java	Disable default residual/raw‐hit plots, add large‐2D plots toggle
recon/.../HpsReconParticleDriver.java	Switch vertexer to use perigee field, update IP→perigee state indexing
pom.xml	Bump `<lcsimVersion>` to 4.5.0 and add GitHub Packages repo
.github/workflows/test.yml	Move from Java 1.8 to JDK 21, configure `GITHUB_TOKEN`
.github/dependabot.yml	Add daily Dependabot updates for Maven and GitHub Actions

Comments suppressed due to low confidence (2)

tracking/src/main/java/org/hps/recon/tracking/kalman/KalmanInterface.java:391

[nitpick] Inline author/comment tags and dates may be better captured in commit history; remove dated comments or convert to descriptive Javadoc.

    // 5/10/25:  change variable name from alphaCenter to alpha to avoid confusion -- mgraham

Copilot · 2025-07-01T00:43:26Z

tracking/src/main/java/org/hps/recon/tracking/kalman/KalTrack.java

+	    System.out.println(this.getClass().getName()+"::getHelixAtPlane:  Couldn't find a site???");
+	}else{
+	    if(debug){
+		System.out.println(this.getClass().getName()+"::getHelixAtPlane:");
+		closeSite.print("closest measurement site");
+	    }		    
+	}


If closeSite is null, the method proceeds and will dereference closeSite, causing an NPE. Add an early return or throw a clear exception when no site is found.

Suggested change

System.out.println(this.getClass().getName()+"::getHelixAtPlane: Couldn't find a site???");

}else{

if(debug){

System.out.println(this.getClass().getName()+"::getHelixAtPlane:");

closeSite.print("closest measurement site");

}

}

throw new IllegalStateException(this.getClass().getName() + "::getHelixAtPlane: Couldn't find a site.");

}

if(debug){

System.out.println(this.getClass().getName()+"::getHelixAtPlane:");

closeSite.print("closest measurement site");

}

tracking/src/main/java/org/hps/recon/tracking/kalman/KalTrack.java

tracking/src/main/java/org/hps/recon/tracking/kalman/KalmanInterface.java

Copilot · 2025-07-01T00:43:28Z

tracking/src/main/java/org/hps/recon/tracking/kalman/HelixState.java

            helixAtTarget.print("helix with pivot at final plane");
            pln.X().print("origin of final field system in global system");
            Rot.print("rotation matrix from global to final field system");
+	    System.out.println("Return parameters with pivot at the intersection:: "+pivotAtIntersect); 


Debug System.out.println calls remain in the RK propagator; replace with a proper logger or remove for production.

Suggested change

System.out.println("Return parameters with pivot at the intersection:: "+pivotAtIntersect);

logger.log(Level.FINE, "Return parameters with pivot at the intersection: {0}", pivotAtIntersect);

baltzell · 2025-07-01T14:54:20Z

The (new) separate build-only, no-test, CI job now passes:)

mgignac · 2025-07-02T12:43:47Z

It looks like the reference files need to be updated? Looking at the failed tests, the momentum/mass/etc are different (which is expected for these changes):
Error: Failures: Error: EngRun2015MollerReconTest>ReconTest.testRecon:380->ReconTest.comparePlots:252->ReconTest.compareTrees:272->ReconTest.compareHistograms:293 Bin 2 is different for: Moller Bottom Track Momentum expected:<2> but was:<0> Error: EngRun2015V0ReconTest>ReconTest.testRecon:380->ReconTest.comparePlots:252->ReconTest.compareTrees:272->ReconTest.compareHistograms:293 Bin 0 is different for: V0 Bottom Track Momentum expected:<45> but was:<29> Error: PhysRun2016MollerReconTest>ReconTest.testRecon:380->ReconTest.comparePlots:252->ReconTest.compareTrees:272->ReconTest.compareHistograms:293 Bin 37 is different for: Moller Bottom Track Momentum expected:<2> but was:<0> Error: PhysRun2016V0ReconTest>ReconTest.testRecon:380->ReconTest.comparePlots:252->ReconTest.compareTrees:272->ReconTest.compareHistograms:293 Bin 27 is different for: V0 Invariant Mass expected:<1> but was:<0>

…ode that makes vertex to use bfield at svt center for gbl tracks

…t ReconParticleDriver to master and update HpsReconParticleDriver to use type in ReconParticle

…ixtrackstates

baltzell · 2025-07-09T11:14:09Z

Retriggered actions now manually to see if SLAC maven repos are back online ...

…vs kalman track

bloodyyugo

Finally!

bloodyyugo and others added 10 commits May 8, 2025 16:01

first set of changes; add switch in propagateRK to return helix at pl…

093751f

…ane intercept; start to use this in TrackStates

add option to get the helix with pivot point as the plane intersect

9768d82

add blocal and make computeMomentum use only class variables

9cccbc3

use bLocal for the vertexing

62a880a

add jeffersonlab github maven repos (for lcsim)

f89bf3a

Add dependabot.yml (#1087)

9095274

* add dependabot.yml * fix oops * comments not allowed * bugfix * cleanup

new lcsim version (maven repo hosted on github only)

0ff72c1

try 21

49c039b

single-thread tests for now

88fa808

try a secret token

d74d5d5

baltzell changed the title ~~Lcsim 4.5.0 fixtrackstates~~ lcsim 4.5.0 plus fixtrackstates Jul 1, 2025

baltzell mentioned this pull request Jul 1, 2025

Fixtrackstates #1101

Closed

baltzell requested review from bloodyyugo, Copilot, mgignac and rodwyer100 July 1, 2025 00:41

Copilot AI reviewed Jul 1, 2025

View reviewed changes

baltzell added 2 commits July 1, 2025 10:50

restore multithread on test job

7bf2368

add separate build-only, no-test, CI job

bc3a036

bloodyyugo added 5 commits July 2, 2025 15:20

use AtPerigee instead of AtIP for a bunch of methods. put switch in c…

f19399b

…ode that makes vertex to use bfield at svt center for gbl tracks

ReconstructedParticle already has a member called track type so rever…

f62886e

…t ReconParticleDriver to master and update HpsReconParticleDriver to use type in ReconParticle

add tests for kalman tracking; FEE, Moller, and V0 2016

69b74af

Merge remote-tracking branch 'origin/kalman-tests' into lcsim-4.5.0-f…

538e97b

…ixtrackstates

remove printouts

e777361

baltzell mentioned this pull request Jul 7, 2025

lcsim 4.5.0 #1114

Closed

bloodyyugo added 2 commits July 10, 2025 07:01

revert recon particle drivers since getType did not actually get gbl …

f0e79f1

…vs kalman track

use the proper way to get track states

544e002

bloodyyugo approved these changes Jul 15, 2025

View reviewed changes

mgignac approved these changes Jul 15, 2025

View reviewed changes

bloodyyugo merged commit 3149520 into master Jul 15, 2025
2 of 3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lcsim 4.5.0 plus fixtrackstates #1115

lcsim 4.5.0 plus fixtrackstates #1115

Uh oh!

baltzell commented Jul 1, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jul 1, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jul 1, 2025

Uh oh!

baltzell commented Jul 1, 2025

Uh oh!

mgignac commented Jul 2, 2025

Uh oh!

baltzell commented Jul 9, 2025

Uh oh!

bloodyyugo left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	System.out.println("Return parameters with pivot at the intersection:: "+pivotAtIntersect);
	logger.log(Level.FINE, "Return parameters with pivot at the intersection: {0}", pivotAtIntersect);

lcsim 4.5.0 plus fixtrackstates #1115

lcsim 4.5.0 plus fixtrackstates #1115

Uh oh!

Conversation

baltzell commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jul 1, 2025

Choose a reason for hiding this comment

Uh oh!

baltzell commented Jul 1, 2025

Uh oh!

mgignac commented Jul 2, 2025

Uh oh!

baltzell commented Jul 9, 2025

Uh oh!

bloodyyugo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

baltzell commented Jul 1, 2025 •

edited

Loading