Update deps #1
Open
Update deps #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Was it not working with its existing dependencies? |
|
@JeffreyATW - It only worked when I updated react-scripts. The rest I updated after as a bonus. When I just updated react scripts, things were properly aligned. That is how I know the update messed it up. It mostly works though. |
|
It's very likely the misalignment was caused by upgrading |
|
@JeffreyATW - leave it open, I will probably fix it. |
JeffreyATW
requested changes
Jan 17, 2018
| @@ -1 +1 @@ | |||
| Testing out [create-react-app](https://github.com/facebookincubator/create-react-app) and [react-game-kit](https://github.com/FormidableLabs/react-game-kit). | |||
| T esting out [create-react-app](https://github.com/facebookincubator/create-react-app) and [react-game-kit](https://github.com/FormidableLabs/react-game-kit). | |||
|
I was reading through the commit history of react-game-kit, so I thought we didn't need to monkey patch, but I added it back when I realize it was reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
Thanks for writing this example, to get it working I updated a few dependencies. For some reason it is off center (and off screen on smaller screens) because of the update. Haven't had time to debug it, but I figure I'll leave it here.
Cheers,
Bryan