Skip to content

Relax short activity card validation #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Laksh-star wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Relax short activity card validation #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dayflow/Dayflow/Core/AI/AgentCLISupport+Parsing.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ extension AgentCLISupporting {
durationMinutes = Double(endSeconds - startSeconds) / 60.0
}

if durationMinutes < 10 && index < cards.count - 1 {
if durationMinutes < 1 && index < cards.count - 1 {
let msg = String(
format: "Card %d '%@' is only %.1f minutes long", index + 1, card.title, durationMinutes)
return (false, msg)
Expand Down
5 changes: 3 additions & 2 deletions Dayflow/Dayflow/Core/AI/GeminiDirectProvider+ActivityCards.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,8 +904,9 @@ extension GeminiDirectProvider {
durationMinutes = Double(endSeconds - startSeconds) / 60.0
}

// Check if card is too short (except for last card)
if durationMinutes < 10 && index < cards.count - 1 {
// Reject only invalid or near-zero middle fragments. Short context
// transitions should not fail an otherwise usable activity-card batch.
if durationMinutes < 1 && index < cards.count - 1 {
return (
false,
"Card \(index + 1) '\(card.title)' is only \(String(format: "%.1f", durationMinutes)) minutes long"
Expand Down
14 changes: 11 additions & 3 deletions Dayflow/DayflowTests/CodexClaudeProviderTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,19 +150,27 @@ final class CodexClaudeProviderTests: XCTestCase {
)
}

func testLegacyCardDurationOnlyRejectsShortNonFinalCards() {
func testLegacyCardDurationAllowsShortTransitionsButRejectsInvalidRanges() {
XCTAssertTrue(
claudeProvider.validateTimeline([
card(start: "9:00 AM", end: "10:30 AM", title: "Long card"),
card(start: "10:30 AM", end: "10:35 AM", title: "Short final card"),
]).isValid
)
XCTAssertFalse(

XCTAssertTrue(
claudeProvider.validateTimeline([
card(start: "9:00 AM", end: "9:05 AM", title: "Short non-final card"),
card(start: "9:00 AM", end: "9:05 AM", title: "Short transition"),
card(start: "9:05 AM", end: "9:20 AM", title: "Final card"),
]).isValid
)

XCTAssertFalse(
claudeProvider.validateTimeline([
card(start: "9:00 AM", end: "9:00 AM", title: "Invalid non-final card"),
card(start: "9:00 AM", end: "9:20 AM", title: "Final card"),
]).isValid
)
}

func testLegacyCardValidationNormalizesConfiguredCategories() {
Expand Down