Support for "Apple Development" and "Apple Distribution" certificates#5238
Open
yannickpulver wants to merge 7 commits intoJetBrains:masterfrom
Open
Support for "Apple Development" and "Apple Distribution" certificates#5238yannickpulver wants to merge 7 commits intoJetBrains:masterfrom
yannickpulver wants to merge 7 commits intoJetBrains:masterfrom
Conversation
yannickpulver
changed the title
Member
|
Hi @yannickpulver, |
Author
|
Hi @kropp I tried last year but failed to validate it. I could try to give it another go, but if there's somebody internally working on that I'm happy to close it. |
…nd Mac Development certificates for macOS signing jpackage only recognizes "Developer ID Application" and "3rd Party Mac Developer Application" certificate prefixes — it prepends these to the identity, breaking newer Apple certificate types. Skip jpackage signing for unsupported cert types and let the existing MacSigner handle it. Also fixes passing raw identity instead of fullDeveloperID to jpackage. Fixes CMP-4272, relates to CMP-7651
jpackage only signs PKGs with "Developer ID Installer" and "3rd Party Mac Developer Installer" prefixes. For newer certificate types (Apple Distribution, Mac App Distribution), sign the PKG post-creation using productsign. Tries both "3rd Party Mac Developer Installer" and "Mac Installer Distribution" as candidates since Apple still issues certs with the legacy name despite documenting the new one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CMP-4272 macOS signing failing with modern Apple certificates and bare signing identities.
What changed
Apple DevelopmentMac DevelopmentApple DistributionMac App Distributionjpackageand existing keychains:3rd Party Mac Developer Application3rd Party Mac Developer InstallerMac DeveloperDeveloper ID Applicationproductsignfor PKG signing whenjpackagecannot sign newer distribution certificate typesTesting
createDistributablewith modern certificate resolutionpackagePkgend-to-end with:Apple Distribution3rd Party Mac Developer Installer):composeApp:packageReleasePkg -PappStore=truesucceeded and produced a signed.pkg:composeApp:packageReleaseDmgsucceeded and produced a.dmgcontaining a signed.appRelease Notes
Fixes - Desktop