Inline code with correct indentation #3204
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Formatting was applied to a detached block and then per-statement after insertion, which broke Python suite indentation and disturbed nearby comments. Now: - Perform one context-aware indentation adjustment (adjustLineIndent) over the contiguous inserted range after insertion; commit/unblock the document first. - Detect and delete redundant self-assignment (e.g., `x = x`) from single-return inlining.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Formatting was applied to a detached block and then per-statement after insertion, which broke Python suite indentation and disturbed nearby comments.
Now:
x = x) from single-return inlining.Fixes https://youtrack.jetbrains.com/issue/PY-83746/Inline-refactoring-deletes-code
Fixes https://youtrack.jetbrains.com/issue/PY-83747/Inline-refactoring-creates-syntax-error-with-wrong-indentation