-
Notifications
You must be signed in to change notification settings - Fork 5.6k
ENH: Option to apply type renderers to subclases fo the target type #3223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dangreb
wants to merge
18
commits into
JetBrains:master
Choose a base branch
from
dangreb:subclass-wide-type-renderers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to subclass-wide-type-renderers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

While tending to an issue regarding Type Renderers on PyCharm, I thought it would be nice if we had an option to apply certain customized renderers to subclasses of the indiccated Target Type. It's been ages since i dabbled with Java like code so i went ahead and did it!
I also did some cosmetics for the customizing GUI. The new checkbox labeled "Apply to subclasses" makes so that instances of any subclasses of the indicated Target Type will receive the very same treatment from the IDE, in regards to that singular renderer of course.
I need to test it further still, so i'll open this draft for now, also so we can ponder over its relevance and viability of course!
cheers!