[JEWEL-1027] Fix the branch comparison script #3252
Closed
+214
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faogustavo
approved these changes
Oct 6, 2025
|
@nebojsa-vuksic you were saying it's still not picking up all the changes. Any suggested improvements? I'll also apply your suggestion to only check these files in the build dir:
|
nebojsa-vuksic
approved these changes
Oct 16, 2025
|
I'll wait to merge to get the requested changes done first |
The script had issues in picking up which commits to look for and did not account for things like the time difference between a commit happening on master and its cherry picks happening on a branch. This fixes the issue and cleans up the script code, improving logging too. It also adds a few flags to make the output of the script a bit more manageable.
rock3r
force-pushed
the
sebp/JEWEL-1027_fix-branch-comparison-script
branch
from
ddee0e2 to
deca6ab
Compare
|
Done the requested change, it only checks those two build files now. |
|
Ready to merge |
|
what is this
…On Thu, 9 Oct, 2025, 10:15 pm Sebastiano Poggi, ***@***.***> wrote:
*rock3r* left a comment (JetBrains/intellij-community#3252)
<#3252 (comment)>
@nebojsa-vuksic <https://github.com/nebojsa-vuksic> you were saying it's
still not picking up all the changes. Any suggested improvements? I'll also
apply your suggestion to only check these files in the build dir:
-
community/build/src/org/jetbrains/intellij/build/JewelMavenArtifacts.kt
- community/build/src/JewelMavenArtifactsBuildTarget.kt
—
Reply to this email directly, view it on GitHub
<#3252 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BLD53BCS5VCLUYO43PI4KML3W2GJ3AVCNFSM6AAAAACHQJRPH2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGOBWGY3TANBXGY>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script had issues in picking up which commits to look for and did not account for things like the time difference between a commit happening on master and its cherry picks happening on a branch.
This fixes the issue and cleans up the script code, improving logging too. It also adds a few flags to make the output of the script a bit more manageable.