Fix false "Unnecessary parentheses" for function types in type patterns #SCL-21577 #705
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes SCL-21577: Wrong "Unnecessary parentheses" warning shown in type pattern with function literal
Problem
IntelliJ was incorrectly flagging parentheses around function types in type patterns as unnecessary:
Without the parentheses, the code would be parsed differently and wouldn't compile.
Solution
Extended the
NeededParenthesisAroundFunctionalTypecheck inParenthesizedElement.scalato recognize that parentheses are necessary when:ScParameterType(already handled)ScTypePattern(newly added)Testing
testSCL21577_FunctionTypeInPatterninScalaUnnecessaryParenthesesInspectionTest_Scala3Files Changed
scala/scala-impl/src/org/jetbrains/plugins/scala/extensions/ParenthesizedElement.scalascala/scala-impl/test/org/jetbrains/plugins/scala/codeInspection/parentheses/ScalaUnnecessaryParenthesesInspectionTest.scala