Skip to content

Add a way to disable Compose mapping tasks from gradle plugin #5525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2025
Merged

Add a way to disable Compose mapping tasks from gradle plugin #5525

merged 1 commit into from
Oct 23, 2025

Conversation

@ShikaSD
Copy link
Collaborator

@ShikaSD ShikaSD commented Oct 15, 2025 •
edited
Loading

Gates the feature in case of unexpected breakages.

Fixes: KT-81827

@ShikaSD ShikaSD requested review from a team as code owners October 15, 2025 18:51
@KotlinBuild KotlinBuild force-pushed the prr/ashikov/flag-mapping-files branch from 19fa913 to 1387952 Compare October 15, 2025 18:55
@ShikaSD
Copy link
Collaborator Author

ShikaSD commented Oct 15, 2025

/safe-merge

@tbogdanova
Copy link
Collaborator

/test-private

@tbogdanova tbogdanova requested review from Badya and removed request for tbogdanova October 16, 2025 06:18
@tbogdanova
Copy link
Collaborator

/test-private

@SmialyKot SmialyKot requested review from SmialyKot and removed request for Badya October 16, 2025 13:53
SmialyKot
SmialyKot previously approved these changes Oct 16, 2025
View reviewed changes
@SmialyKot SmialyKot dismissed their stale review October 16, 2025 13:53

Test dismiss

@SmialyKot
Copy link
Contributor

/test-private

@SmialyKot SmialyKot removed the request for review from Herudaio October 17, 2025 07:36
SmialyKot
SmialyKot previously approved these changes Oct 17, 2025
View reviewed changes
Copy link
Contributor

@SmialyKot SmialyKot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internal aggregate passed

@Tapchicoma Tapchicoma self-assigned this Oct 21, 2025
@ShikaSD ShikaSD force-pushed the prr/ashikov/flag-mapping-files branch from 1387952 to 6a72740 Compare October 21, 2025 14:35
Tapchicoma
Tapchicoma previously approved these changes Oct 21, 2025
View reviewed changes
@ShikaSD ShikaSD dismissed stale reviews from Tapchicoma and SmialyKot via dbabe29 October 21, 2025 15:51
@ShikaSD ShikaSD force-pushed the prr/ashikov/flag-mapping-files branch from 6a72740 to dbabe29 Compare October 21, 2025 15:51
Tapchicoma
Tapchicoma previously approved these changes Oct 21, 2025
View reviewed changes
@Tapchicoma
Copy link
Contributor

/test-private

@ShikaSD ShikaSD force-pushed the prr/ashikov/flag-mapping-files branch from dbabe29 to e77ab74 Compare October 22, 2025 09:37
@SmialyKot
Copy link
Contributor

/test-private

@SmialyKot
Copy link
Contributor

/test-public

SmialyKot
SmialyKot previously approved these changes Oct 22, 2025
View reviewed changes
@SmialyKot
Copy link
Contributor

/test-public

@ShikaSD
Copy link
Collaborator Author

ShikaSD commented Oct 23, 2025

/safe-merge

@KotlinBuild
Copy link

Quality gate is triggered at https://buildserver.labs.intellij.net/build/806176456 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5525/safe-merge
Commit: 0c05925

@KotlinBuild
Copy link

Quality gate failed. See https://buildserver.labs.intellij.net/build/806176456 to get full insight.

@ShikaSD
Add a way to disable Compose mapping tasks from gradle plugin
afb3055 
Gates the feature in case of unexpected breakages.

Fixes: KT-81827
@ShikaSD ShikaSD dismissed stale reviews from SmialyKot and Tapchicoma via afb3055 October 23, 2025 15:51
@ShikaSD ShikaSD force-pushed the prr/ashikov/flag-mapping-files branch from e77ab74 to afb3055 Compare October 23, 2025 15:51
@SmialyKot
Copy link
Contributor

/test-private

@kotlin-safe-merge
Copy link

Private aggregate run triggered at https://buildserver.labs.intellij.net/build/806300740 — use this link to monitor results.

@ShikaSD
Copy link
Collaborator Author

ShikaSD commented Oct 23, 2025

/safe-merge

@kotlin-safe-merge
Copy link

Command rejected: Changes outside compose/parcelize require a successful private aggregate run. No successful private aggregate run was found.

@ShikaSD
Copy link
Collaborator Author

ShikaSD commented Oct 23, 2025

/safe-merge

@KotlinBuild
Copy link

Quality gate is triggered at https://buildserver.labs.intellij.net/build/806414847 — use this link to get full insight.

Quality gate was triggered with the following revisions:

kotlin
Branch: refs/merge/GITHUB-5525/safe-merge
Commit: ab7e84a

@KotlinBuild
Copy link

Quality gate finished successfully.

@KotlinBuild KotlinBuild merged commit 8ac1eeb into master Oct 23, 2025
1 check passed
@KotlinBuild KotlinBuild deleted the prr/ashikov/flag-mapping-files branch October 23, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tapchicoma Tapchicoma Tapchicoma approved these changes

@SmialyKot SmialyKot SmialyKot approved these changes

Assignees

@Tapchicoma Tapchicoma

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ShikaSD @tbogdanova @SmialyKot @Tapchicoma @KotlinBuild