[KT-48068] Add opt-in support for NSEnum for Kotlin Native iOS via an annotation #5539
+598
−51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanhaustein
requested review from
a team,
DmitryNekrasov,
fzhinkin,
ilya-g and
qwwdfsad
as code owners
Contributor
|
/test-private |
|
Failed to process command due to an unexpected exception. |
native/objcexport-header-generator/src/org/jetbrains/kotlin/backend/konan/objcexport/stubs.kt
Outdated
Show resolved
Hide resolved
native/objcexport-header-generator/src/org/jetbrains/kotlin/backend/konan/objcexport/stubs.kt
Outdated
Show resolved
Hide resolved
native/native.tests/testData/framework/objcexport/nativeEnum.kt
Outdated
Show resolved
Hide resolved
kotlin-native/runtime/src/main/kotlin/kotlin/native/Annotations.kt
Outdated
Show resolved
Hide resolved
...-generator/impl/k1/src/org/jetbrains/kotlin/backend/konan/objcexport/ObjCExportTranslator.kt
Outdated
Show resolved
Hide resolved
...-generator/impl/k1/src/org/jetbrains/kotlin/backend/konan/objcexport/ObjCExportTranslator.kt
Outdated
Show resolved
Hide resolved
...-generator/impl/k1/src/org/jetbrains/kotlin/backend/konan/objcexport/ObjCExportTranslator.kt
Outdated
Show resolved
Hide resolved
...er/ir/backend.native/src/org/jetbrains/kotlin/backend/konan/objcexport/ObjCExportCodeSpec.kt
Outdated
Show resolved
Hide resolved
...bjcexport-header-generator/src/org/jetbrains/kotlin/backend/konan/objcexport/StubRenderer.kt
Outdated
Show resolved
Hide resolved
Contributor
|
The K2 (Analysis API, aka AA) implementation is missing, which makes the new test fail in this mode. ./gradlew :native:objcexport-header-generator:testAnalysisApi --tests "org.jetbrains.kotlin.backend.konan.tests.ObjCExportHeaderGeneratorTest"to reproduce. Related code: |
Contributor
|
Another thing to fix: adding a declaration to stdlib requires updating the ABI dump. |
stefanhaustein
changed the title
Author
I have added this, but AA emits the a comment about the annotation whereas K1 does not... Any suggestions how to resolve this? Current state is the AA output |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically implementing the feature suggested here: https://youtrack.jetbrains.com/issue/KT-48068