Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ QD-10856 Create effective configuration in qodana cli #527

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MekhailS
Copy link
Contributor

  • in native mode (or in docker execution) effective configuration is created using config-loader-cli.jar, it's passed to linter and used for CLI
  • in diff-start, diff-end mode, keep old behaviour (preserve bootstrap from new hash)
  • refactor: separate QodanaYamlConfig objects for each context
  • config-loader-cli.jar is downloaded by .sh script, verified using checksum file
  • functions related to loading of qodana yaml now demonstrate that they don't load effective configuration
  • tests

Pull Request Details

Description

Related Issue

Motivation and Context

How Has This Been Tested

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My commit messages are styled with gitmoji
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link

github-actions bot commented Feb 22, 2025

Qodana for Go

129 new problems were found

Inspection name Severity Problems
Unused exported function 🔶 Warning 80
Unused constant 🔶 Warning 26
Unused global variable 🔶 Warning 15
Constant condition 🔶 Warning 2
Imported package name as a name identifier 🔶 Warning 2
Error may be not nil 🔶 Warning 1
Comment of exported element starts with the incorrect name ◽️ Notice 3

☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@MekhailS MekhailS force-pushed the shagvaliev/effectiveyaml branch from b12cfa3 to 44ca1fb Compare February 22, 2025 12:17
- in native mode (or in docker execution) effective configuration is created using `config-loader-cli.jar`, it's passed to linter and used for CLI
- in diff-start, diff-end mode, keep old behaviour (preserve bootstrap from new hash)
- refactor: separate QodanaYamlConfig objects for each context
- config-loader-cli.jar is downloaded by .sh script, verified using checksum file
- functions related to loading of qodana yaml now demonstrate that they don't load effective configuration
- tests
@MekhailS MekhailS force-pushed the shagvaliev/effectiveyaml branch from 728a2ec to 34ac6fa Compare February 22, 2025 13:33
@MekhailS MekhailS requested a review from avafanasiev February 22, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant