Skip to content
This repository was archived by the owner on Jun 30, 2025. It is now read-only.

Conversation

@himyouten
Copy link

No description provided.

@himyouten
Copy link
Author

I haven't done any tests...

@fstehle
Copy link
Contributor

fstehle commented Oct 14, 2016

Thanks a lot for your contribution.
The code looks great so far.
Can you please add a test (tests/test_fastly_vcl.py) for it (look at https://github.com/Jimdo/ansible-fastly/blob/540bdb0620c12319133c396eeae137ab702480fa/tests/test_fastly_gzip.py for an example)?
Can you please enhance the README (https://github.com/Jimdo/ansible-fastly/blob/c7a1e13b7f624d5d7292d26c93d0ffbdfba7ac55/README.md#documentation) for the vcls module option for it as well?

@himyouten
Copy link
Author

I've added S3 logging support and updated the README, but I can't figure out the tests, sorry. If someone else wants to complete the tests that'd be grand!

@himyouten
Copy link
Author

I figured out the tests! Wrote tests for all new functions - and added a paragraph for how to do the tests for next time I might need it :-)

@xiongchiamiov
Copy link

It would be lovely if the vcl could be provided from a file instead of only an inline string; that would help keep things tidy when dealing with lots of vcl. But perhaps that's something out of the scope of this pull.

@himyouten
Copy link
Author

Hi - sorry - been a while - but I recently just added dictionary support - which required doing a clone instead of a full rebuild. Unfortunately, I don't think I'll get around to doing the tests this time. Its a pretty major rework.

@himyouten
Copy link
Author

@xiongchiamiov I'd love to be able to do that too! But I haven't had the time to figure out how to use Ansible's templating calls. I currently load the files using vars and lookup('template')

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants