fix(create-nodes): allow setting the values of elements in createnodes - #363
Merged
Conversation
Collaborator
Author
|
Hm, something is going wrong with namespaces. Give me a bit of time to fix that |
Collaborator
Author
|
Those work now. @JoernT this is ready to review! |
rkottmann
reviewed
Jul 23, 2026
rkottmann
left a comment
rkottmann
left a comment
Contributor
There was a problem hiding this comment.
May I ask to remove the xlizenz naming from demo and in content?
Contributor
|
@rkottmann we'll do |
DrRataplan
force-pushed
the
create-nodes-child-elements
branch
from
July 23, 2026 11:12
9ad8a5e to
82eddfb
Compare
DrRataplan
changed the title
DrRataplan
force-pushed
the
create-nodes-child-elements
branch
from
July 28, 2026 08:57
82eddfb to
118a99b
Compare
And refactor a bit, process more as path steps, and see both attributes and elements as value tests Fixes #362
DrRataplan
force-pushed
the
create-nodes-child-elements
branch
from
July 28, 2026 08:58
118a99b to
3484991
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And refactor a bit, process more as path steps, and see both attributes and elements as value tests
Fixes #362
What does this change?
This fixes #362 by setting values for elements if the path refers to them
How was this tested?
npm test) passnpm run lint) passesRelated issues
Closes #362