feat(hooks)!: remove the UserPromptSubmit knowledge-recall hook - #12
Merged
Conversation
Rely on the model invoking the KB via the recall skill/MCP on demand rather than an automatic prompt-context-fetch hook (it added latency to every prompt and blew its timeout budget). Removes the hook script + templates + installer wiring + manifest entries for BOTH Claude and Codex; keeps the recall skill, the knowledge MCP, and the PreToolUse/Stop capture+digest hooks intact. Updates the agent-session-bootstrap skill docs and the hook-scope-surface test. BREAKING CHANGE: installs no longer register a UserPromptSubmit recall hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the automatic UserPromptSubmit KB-recall hook entirely, for both Claude and Codex — the model now pulls KB context on demand via the recall skill/MCP instead of a per-prompt context-fetch hook (which added latency and blew its 5s timeout). Deletes the hook script + templates + installer wiring + manifest entries; keeps the recall skill, knowledge MCP, and the PreToolUse/Stop capture+digest hooks. All gates green: render --check, manifest validate, self-test, tsc, eslint, dependency-cruiser, vitest 100% (506 tests). Supersedes the timeout-tuning in #11.
BREAKING CHANGE: fresh installs no longer register a UserPromptSubmit recall hook.