Skip to content

removed inheritance from Nette\Object and added trait Nette\SmartObject #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aplitax wants to merge 5 commits into
base: master
Choose a base branch
from
Open

removed inheritance from Nette\Object and added trait Nette\SmartObject #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3408843
removed inheritance from Nette\Object
May 16, 2018
0fea023
removed inheritance from Nette\Object
May 16, 2018
3fc710c
Merge branch 'master' of https://github.com/aplitax/TextAsFileResponse
Oct 12, 2018
d42ced3
Merge branch 'master' of https://github.com/aplitax/TextAsFileResponse
Oct 12, 2018
245a906
Merge branch 'master' of https://github.com/aplitax/TextAsFileResponse
Oct 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
language: php
php:
- 5.3.3
- 5.4
- 5.5
- 5.6
- 7.0
- 7.1
- 7.2
- hhvm

matrix:
Expand Down
1 change: 1 addition & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
}
],
"require": {
"php": ">=5.6.0",
"nette/application": "~2.2"
},
"require-dev": {
Expand Down
4 changes: 3 additions & 1 deletion src/Joseki/Application/Responses/TextAsFileResponse.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@
use Nette\Http\IResponse as HttpIResponse;
use Nette\Object;

class TextAsFileResponse extends Object implements IResponse
class TextAsFileResponse implements IResponse
{
use \Nette\SmartObject;
Copy link
Member

@castamir castamir May 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 5 spaces instead of 4

Copy link
Author

@aplitax aplitax Oct 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected :-)


/** @var string */
private $name;

Expand Down