-
Notifications
You must be signed in to change notification settings - Fork 6
Set version range in manifest, up to local swift version to resolve #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Set version range in manifest, up to local swift version to resolve #22
Conversation
|
Sorry I've not looked at his yet, I've been swamped 😄 I will look at this properly when I get the chance. The main thing I want to check is that the macro actually compiles and tests pass when using all of these different versions (or at least the latest of major version). |
No problem at all! I haven't had much chance to look into this myself. Appreciate you looking 👍 |
JosephDuffy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to check CI works so may push more commits.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 98.80% 98.58% -0.22%
==========================================
Files 12 12
Lines 3752 2976 -776
==========================================
- Hits 3707 2934 -773
+ Misses 45 42 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Maybe it will need `use_oidc`?
1.0.1 is very old. Support for parsing `swift test` output (or specifically Swift Testing?) was in 2.12.0.
It actually support Swift 5.9, but we just need down to 6.0 right now
ba13beb to
c3573a9
Compare
Here's the PR to set the version to a range. It looks like depending on your local Swift version, it will pick the version compatible with your current toolchain, according to their GitHub repo.