Skip to content

fix(ref:1601): Relax FormValueControl implementation #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ThiloAschebrock wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(ref:1601): Relax FormValueControl implementation #1602

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions projects/ngx-mask-lib/src/lib/ngx-mask.directive.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import {
HostListener,
inject,
untracked,
booleanAttribute,
} from '@angular/core';
import type {
ControlValueAccessor,
Expand All @@ -18,7 +19,7 @@ import type {
Validator,
} from '@angular/forms';
import { NG_VALIDATORS, NG_VALUE_ACCESSOR } from '@angular/forms';
import type { FormValueControl, ValidationError, WithOptionalField } from '@angular/forms/signals';
import type { FormValueControl } from '@angular/forms/signals';

import type { NgxMaskConfig } from './ngx-mask.config';
import { NGX_MASK_CONFIG, timeMasks, withoutValidation } from './ngx-mask.config';
Expand Down Expand Up @@ -73,15 +74,8 @@ export class NgxMaskDirective
public instantPrefix = input<NgxMaskConfig['instantPrefix'] | null>(null);

public value = model<string>('');
public errors = input<readonly WithOptionalField<ValidationError>[]>([]);
public disabled = input<boolean>(false);
public disabled = input(false, { transform: booleanAttribute });
public touched = model<boolean>(false);
Copy link
Author

@ThiloAschebrock ThiloAschebrock Feb 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angular will change the FormValueControl interface and break up touched, see angular/angular#67100 in Angular 22.

public dirty = input<boolean>(false);
public invalid = input<boolean>(false);
public pending = input<boolean>(false);
public readonly = input<boolean>(false);
public required = input<boolean>(false);
public name = input<string>('');

public maskFilled = output<void>();

Expand Down