-
Notifications
You must be signed in to change notification settings - Fork 254
move stack to Vector #938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oscardssmith
wants to merge
6
commits into
master
Choose a base branch
from
os/move-stack-to-vector
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
move stack to Vector #938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By my measurements, it's a bunch faster for this workload (this may be new as of Julia 1.11) ``` julia> function f3(d, n) for i in 1:n push!(d, i) pop!(d) end end f3 (generic function with 1 method) julia> @benchmark f3(d, 1000) evals=1 setup = (d=Vector{Int}()) BenchmarkTools.Trial: 10000 samples with 1 evaluation per sample. Range (min … max): 789.000 ns … 10.042 μs ┊ GC (min … max): 0.00% … 0.00% Time (median): 797.000 ns ┊ GC (median): 0.00% Time (mean ± σ): 823.878 ns ± 158.991 ns ┊ GC (mean ± σ): 0.00% ± 0.00% ▅█▅▁▅▄ ▂ ▁▄▃ ▂ ▁ ███████▆▆▄▁▁▁▁▁▁▇██▃███▇▇▆▇█▆▆▅▄▄▄▄▄▅▄▅▄▆▇▇▆▆▇▆▆▆▅▅▄▁▄▁▃▃▄▅██ █ 789 ns Histogram: log(frequency) by time 1.07 μs < Memory estimate: 96 bytes, allocs estimate: 1. julia> @benchmark f3(d, 1000) evals=1 setup = (d=Deque{Int}()) BenchmarkTools.Trial: 10000 samples with 1 evaluation per sample. Range (min … max): 3.667 μs … 28.349 μs ┊ GC (min … max): 0.00% … 0.00% Time (median): 3.803 μs ┊ GC (median): 0.00% Time (mean ± σ): 3.930 μs ± 489.972 ns ┊ GC (mean ± σ): 0.00% ± 0.00% ▁▆█▄▇▅▃▃▂▁▁▂▅▃ ▁ ▁▁ ▁ ▂ ████████████████▇▇██▇▇▆▇█▇███▇▇▆█▇▄▅▄▆▆▆▆▇▇▅▅▅▄▅▅▆▅▄▅▄▄▄▄▆▅ █ 3.67 μs Histogram: log(frequency) by time 5.66 μs < ```
asinghvi17
reviewed
May 1, 2025
asinghvi17
reviewed
May 1, 2025
this will just work with a vector I think
Co-authored-by: Anshul Singhvi <[email protected]>
Co-authored-by: Anshul Singhvi <[email protected]>
Remove outdated Iterators.reverse definition
fingolfin
reviewed
May 16, 2025
tests fail |
Co-authored-by: Max Horn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By my measurements, it's a bunch faster for this workload (this may be new as of Julia 1.11)