-
Notifications
You must be signed in to change notification settings - Fork 149
Update CI #730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #730 +/- ##
==========================================
- Coverage 89.57% 89.23% -0.35%
==========================================
Files 11 11
Lines 969 975 +6
==========================================
+ Hits 868 870 +2
- Misses 101 105 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Test failures were caused by a bug in NaNMath which was fixed in JuliaMath/NaNMath.jl#92. |
@gdalle Thanks for merging but I generally prefer the ColPrac standard
|
I was aware of it but there is no ColPack badge on this repo, should we add it? |
The repo doesn't follow ColPrac officially, and I don't think it should be enforced. As I said, it's my general preference but it might not be shared by other contributors. |
Judging by #749 it seems you're right! I'll keep it it mind for your PRs then |
The PR updates the CI setup a bit:
min
,lts
, and1
Julia versions