preliminary support for multi-arg map and mapreduce with breaking changes#77
Open
ExpandingMan wants to merge 1 commit intoJuliaGPU:mainfrom
Open
preliminary support for multi-arg map and mapreduce with breaking changes#77ExpandingMan wants to merge 1 commit intoJuliaGPU:mainfrom
ExpandingMan wants to merge 1 commit intoJuliaGPU:mainfrom
Conversation
Author
|
This seems to fail on metal, but I don't know why. Everything works fine on me on CPU and with CUDA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for multi-argument
mapand includes breaking API changes for bothmapandmapreduce, as discussed in #54. The main motivation is for multi-argumentmapreduce; that hasn't been added in this PR, but considering that I am proposing breaking changes I wanted to start a discussion before I decide how to do it. If this is merged (whether with the API I'm proposing or some suggested alternative) I will make another PR with multi-argumentmapreduce.There are several alternatives to what I'm proposing here that are non-breaking, including
Tuplewould seem like a bad idea becauseTupleis itself iterable and can be used inBase.map).However, I would find this to be a pretty compelling case for a breaking change since it would make this package consistent with
Baseand also other similar packages such as OhMyThreads.jl.Note that I have not moved
backendto a keyword argument in the various arithmetic functions since there isn't nearly as strong a case that they should be changed, though, for what it's worth, if it were up to me, I'd probably change those also.