Skip to content

Use Printf to report errors from POCL #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 30, 2025
Merged

Use Printf to report errors from POCL #592

merged 3 commits into from
Jun 30, 2025

Conversation

vchuravy
Copy link
Member

  • enable printf in errors again
  • turn off 1.10 testing

Copy link

codecov bot commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 47.59%. Comparing base (f600e50) to head (c1b8f06).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pocl/device/runtime.jl 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #592      +/-   ##
==========================================
- Coverage   47.70%   47.59%   -0.12%     
==========================================
  Files          22       22              
  Lines        1723     1727       +4     
==========================================
  Hits          822      822              
- Misses        901      905       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

github-actions bot commented Apr 25, 2025

Benchmark Results

main c1b8f06... main / c1b8f06...
saxpy/default/Float32/1024 0.0526 ± 0.03 ms 0.0593 ± 0.029 ms 0.887 ± 0.66
saxpy/default/Float32/1048576 0.452 ± 0.02 ms 0.445 ± 0.019 ms 1.02 ± 0.063
saxpy/default/Float32/16384 0.0563 ± 0.027 ms 0.0565 ± 0.027 ms 0.998 ± 0.67
saxpy/default/Float32/2048 0.0436 ± 0.023 ms 0.0445 ± 0.026 ms 0.981 ± 0.78
saxpy/default/Float32/256 0.0605 ± 0.028 ms 0.062 ± 0.028 ms 0.975 ± 0.63
saxpy/default/Float32/262144 0.156 ± 0.024 ms 0.157 ± 0.025 ms 0.991 ± 0.22
saxpy/default/Float32/32768 0.061 ± 0.026 ms 0.0618 ± 0.027 ms 0.987 ± 0.6
saxpy/default/Float32/4096 0.0496 ± 0.024 ms 0.0507 ± 0.024 ms 0.979 ± 0.66
saxpy/default/Float32/512 0.0626 ± 0.029 ms 0.064 ± 0.029 ms 0.978 ± 0.63
saxpy/default/Float32/64 0.0492 ± 0.028 ms 0.0449 ± 0.029 ms 1.1 ± 0.93
saxpy/default/Float32/65536 0.0759 ± 0.026 ms 0.0773 ± 0.026 ms 0.981 ± 0.47
saxpy/default/Float64/1024 0.0526 ± 0.029 ms 0.054 ± 0.029 ms 0.974 ± 0.74
saxpy/default/Float64/1048576 0.599 ± 0.083 ms 0.514 ± 0.055 ms 1.17 ± 0.2
saxpy/default/Float64/16384 0.0589 ± 0.026 ms 0.0602 ± 0.026 ms 0.978 ± 0.61
saxpy/default/Float64/2048 0.0447 ± 0.025 ms 0.0454 ± 0.026 ms 0.984 ± 0.79
saxpy/default/Float64/256 0.0628 ± 0.028 ms 0.062 ± 0.027 ms 1.01 ± 0.63
saxpy/default/Float64/262144 0.167 ± 0.026 ms 0.166 ± 0.026 ms 1.01 ± 0.22
saxpy/default/Float64/32768 0.0689 ± 0.025 ms 0.0725 ± 0.026 ms 0.951 ± 0.49
saxpy/default/Float64/4096 0.0497 ± 0.024 ms 0.0511 ± 0.025 ms 0.974 ± 0.66
saxpy/default/Float64/512 0.0596 ± 0.028 ms 0.0616 ± 0.028 ms 0.967 ± 0.64
saxpy/default/Float64/64 0.0492 ± 0.028 ms 0.0474 ± 0.029 ms 1.04 ± 0.87
saxpy/default/Float64/65536 0.089 ± 0.026 ms 0.0882 ± 0.026 ms 1.01 ± 0.41
saxpy/static workgroup=(1024,)/Float32/1024 0.0489 ± 0.03 ms 0.0549 ± 0.028 ms 0.889 ± 0.7
saxpy/static workgroup=(1024,)/Float32/1048576 0.45 ± 0.021 ms 0.442 ± 0.019 ms 1.02 ± 0.064
saxpy/static workgroup=(1024,)/Float32/16384 0.0555 ± 0.026 ms 0.0533 ± 0.026 ms 1.04 ± 0.7
saxpy/static workgroup=(1024,)/Float32/2048 0.0423 ± 0.025 ms 0.0436 ± 0.026 ms 0.971 ± 0.81
saxpy/static workgroup=(1024,)/Float32/256 0.0589 ± 0.026 ms 0.0569 ± 0.026 ms 1.03 ± 0.67
saxpy/static workgroup=(1024,)/Float32/262144 0.156 ± 0.026 ms 0.152 ± 0.025 ms 1.02 ± 0.24
saxpy/static workgroup=(1024,)/Float32/32768 0.0587 ± 0.026 ms 0.0574 ± 0.026 ms 1.02 ± 0.64
saxpy/static workgroup=(1024,)/Float32/4096 0.0469 ± 0.025 ms 0.0475 ± 0.025 ms 0.986 ± 0.74
saxpy/static workgroup=(1024,)/Float32/512 0.0609 ± 0.028 ms 0.0612 ± 0.027 ms 0.996 ± 0.63
saxpy/static workgroup=(1024,)/Float32/64 0.0561 ± 0.026 ms 0.0542 ± 0.026 ms 1.03 ± 0.69
saxpy/static workgroup=(1024,)/Float32/65536 0.0715 ± 0.026 ms 0.072 ± 0.026 ms 0.993 ± 0.5
saxpy/static workgroup=(1024,)/Float64/1024 0.0492 ± 0.029 ms 0.0541 ± 0.029 ms 0.909 ± 0.73
saxpy/static workgroup=(1024,)/Float64/1048576 0.527 ± 0.052 ms 0.487 ± 0.054 ms 1.08 ± 0.16
saxpy/static workgroup=(1024,)/Float64/16384 0.0597 ± 0.026 ms 0.0561 ± 0.025 ms 1.06 ± 0.66
saxpy/static workgroup=(1024,)/Float64/2048 0.0424 ± 0.024 ms 0.0437 ± 0.026 ms 0.97 ± 0.79
saxpy/static workgroup=(1024,)/Float64/256 0.0612 ± 0.026 ms 0.0595 ± 0.026 ms 1.03 ± 0.64
saxpy/static workgroup=(1024,)/Float64/262144 0.164 ± 0.028 ms 0.164 ± 0.028 ms 1 ± 0.24
saxpy/static workgroup=(1024,)/Float64/32768 0.0628 ± 0.026 ms 0.0671 ± 0.026 ms 0.936 ± 0.53
saxpy/static workgroup=(1024,)/Float64/4096 0.0481 ± 0.026 ms 0.0469 ± 0.023 ms 1.03 ± 0.75
saxpy/static workgroup=(1024,)/Float64/512 0.0613 ± 0.028 ms 0.0609 ± 0.027 ms 1.01 ± 0.64
saxpy/static workgroup=(1024,)/Float64/64 0.0612 ± 0.027 ms 0.0553 ± 0.027 ms 1.11 ± 0.72
saxpy/static workgroup=(1024,)/Float64/65536 0.0849 ± 0.027 ms 0.0883 ± 0.027 ms 0.961 ± 0.42
time_to_load 1.33 ± 0.0039 s 1.34 ± 0.0084 s 0.998 ± 0.0069

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

Base automatically changed from vc/pocl_upstream to main April 28, 2025 08:53
@vchuravy vchuravy mentioned this pull request May 20, 2025
7 tasks
@vchuravy vchuravy marked this pull request as ready for review June 10, 2025 08:21
@vchuravy
Copy link
Member Author

InvalidInstruction: Can't translate llvm instruction:
 Global variable cannot have Function storage class. Consider setting a proper address space.
 Original LLVM value:
@exception.1.8 = private unnamed_addr constant [10 x i8] c"exception\00", align 1
indextest: Error During Test at D:\a\KernelAbstractions.jl\KernelAbstractions.jl\test\testsuite.jl:16
  Got exception outside of a @test
  Failed to translate LLVM code to SPIR-V.

@christiangnrd
Copy link
Member

Seems like all test failures are due to the registry not being up to date when run. I bet this would pass CI if rerun

@vchuravy vchuravy merged commit 4fda411 into main Jun 30, 2025
30 of 32 checks passed
@vchuravy vchuravy deleted the vc/printf branch June 30, 2025 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants