-
Notifications
You must be signed in to change notification settings - Fork 74
Test correct backend in examples test #597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #597 +/- ##
==========================================
- Coverage 47.52% 0.00% -47.53%
==========================================
Files 22 21 -1
Lines 1715 1571 -144
==========================================
- Hits 815 0 -815
- Misses 900 1571 +671 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/examples/histogram.jl b/examples/histogram.jl
index d688d314..0b649647 100644
--- a/examples/histogram.jl
+++ b/examples/histogram.jl
@@ -63,7 +63,7 @@ end
end
-function histogram!(histogram_output, input, groupsize=256)
+function histogram!(histogram_output, input, groupsize = 256)
backend = get_backend(histogram_output)
# Need static block size
kernel! = histogram_kernel!(backend, (groupsize,)) |
The wrong answers show up here, and locally I get a segfault. Is this an issue with the histogram example not having been updated or is this an issue with the implicit bounds checking? Probably the same issue alluded to in JuliaGPU/GPUArrays.jl#590 (comment) |
Like #593 but targeting main