Skip to content

Test correct backend in examples test #597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

christiangnrd
Copy link
Member

Like #593 but targeting main

Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (110d784) to head (1d33a4f).

❗ There is a different number of reports uploaded between BASE (110d784) and HEAD (1d33a4f). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (110d784) HEAD (1d33a4f)
12 10
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #597       +/-   ##
==========================================
- Coverage   47.52%   0.00%   -47.53%     
==========================================
  Files          22      21        -1     
  Lines        1715    1571      -144     
==========================================
- Hits          815       0      -815     
- Misses        900    1571      +671     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic main) to apply these changes.

Click here to view the suggested changes.
diff --git a/examples/histogram.jl b/examples/histogram.jl
index d688d314..0b649647 100644
--- a/examples/histogram.jl
+++ b/examples/histogram.jl
@@ -63,7 +63,7 @@ end
 
 end
 
-function histogram!(histogram_output, input, groupsize=256)
+function histogram!(histogram_output, input, groupsize = 256)
     backend = get_backend(histogram_output)
     # Need static block size
     kernel! = histogram_kernel!(backend, (groupsize,))

@christiangnrd
Copy link
Member Author

The wrong answers show up here, and locally I get a segfault. Is this an issue with the histogram example not having been updated or is this an issue with the implicit bounds checking?

Probably the same issue alluded to in JuliaGPU/GPUArrays.jl#590 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant