Broadcasting fix for Julia 1.5 #370
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah shucks, we don't have GitHub actions set up to use the 1.5 beta yet. That was a bit of a shot in the dark. |
|
Hey Matt, I already backported a patch which should fix the PkgEval error here : #367 |
|
This actually doesn't fix the error, but the tests don't hit it anymore, and since this is only used internally where it is never called this way. |
|
Ah, nice! Thanks for the update, and glad you were able to work around it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! Julia 1.5 very minimally changes what is required of an object to support its use on the left-hand-side of a
.=assignment. This adds the one extra overload that is needed to get tests passing on 1.5 and adds version 1.5 to the CI test matrix.That said, I'm not entirely sure you want to use
.=for this purpose — it's a little strange thatWeightedNormonly supports appearing on the left hand side of a broadcast expression and not on the right. I'd be happy to help you makeWeightedNormwork more fully in broadcast if that makes sense for your uses.See JuliaLang/julia#36105 for the core language discussion and more details if you're interested.