Skip to content

Fix connection hangs + timeout bug - #84

Merged
csvance merged 7 commits into
mainfrom
fix-connection-hang
Dec 17, 2025
Merged

Fix connection hangs + timeout bug#84
csvance merged 7 commits into
mainfrom
fix-connection-hang

Conversation

@csvance

@csvance csvance commented Dec 17, 2025

Copy link
Copy Markdown
Collaborator

This addresses #81

  • Connection timeouts were not being used allowing connections to potentially hang forever
  • deadline was potentially not being provided properly to curl. Take the ceil of the provided number and convert to Clong
  • Allow precompile to fail gracefully if the test server cannot be reached and suggest some potential workarounds to the user

@codecov-commenter

codecov-commenter commented Dec 17, 2025

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 70.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.39%. Comparing base (ad3fd46) to head (921cb79).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/gRPCClient.jl 66.66% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #84      +/-   ##
==========================================
- Coverage   83.91%   83.39%   -0.53%     
==========================================
  Files           7        7              
  Lines         541      554      +13     
==========================================
+ Hits          454      462       +8     
- Misses         87       92       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@csvance
csvance merged commit f110291 into main Dec 17, 2025
13 checks passed
@csvance
csvance deleted the fix-connection-hang branch December 19, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants