2-element size in allocating structured broadcast destination
#1329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jishnub
changed the title
size in allocating structured broadcast destination
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1329 +/- ##
=======================================
Coverage 93.73% 93.74%
=======================================
Files 34 34
Lines 15748 15751 +3
=======================================
+ Hits 14762 14765 +3
Misses 986 986 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we use
size(bc)[1]to construct the destination in structured broadcasting, where we assume that each of the destination types is square. We passn = size(bc)[1]as an argument to the function that allocates the destination, and use(n, n)as the destination size where a 2D matrix needs to be allocated. However, a square destination is not necessary in general, as anUpperHessenbergcurrently supports rectangular parents. We may instead passsize(bc)to the function, and use only the first element when we know the destination to be square from its type. This allows for rectangular destinations wherever necessary.