Skip to content

Replace multi-arg checksquare by map #1380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 20, 2025
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Jun 5, 2025

Following #559, this should reduce some unnecessary allocations in using the multi-argument checksquare.

@dkarrasch
Copy link
Member

What if we changed the definition altogether?

checksquare(A...) = map(checksquare, A)

@dkarrasch
Copy link
Member

I think there are more multi-arg cases.

@jishnub
Copy link
Member Author

jishnub commented Jun 5, 2025

Changing the definition was the suggestion in the issue as well, but I wonder if that might be breaking (although I doubt it). It is documented to return a vector, and the function is listed as public on v1.11+.

@jishnub
Copy link
Member Author

jishnub commented Jun 5, 2025

I've replaced the instances that I could find with the regex checksquare\(([a-zA-Z]+)\,[\s]*([a-zA-Z]+)\)

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.81%. Comparing base (b265fea) to head (15036ff).
Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1380   +/-   ##
=======================================
  Coverage   93.81%   93.81%           
=======================================
  Files          34       34           
  Lines       15717    15717           
=======================================
  Hits        14745    14745           
  Misses        972      972           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jishnub jishnub merged commit b9d8843 into master Jun 20, 2025
4 checks passed
@jishnub jishnub deleted the jishnub/checksquare_map branch June 20, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants