Allow non-float UpperHessenberg matrices#1614
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1614 +/- ##
==========================================
+ Coverage 94.37% 94.38% +0.01%
==========================================
Files 35 35
Lines 16050 16050
==========================================
+ Hits 15147 15149 +2
+ Misses 903 901 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
UpperHessenberg solves use generic fallbacksUpperHessenberg matrices
stevengj
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ideally, I would have liked to rewrite the 2-argldiv!andrdiv!into 3-arg versions to allow for unitful arguments (where source and destination have different units and where the former cannot be simply copied to the latter), but failed in a quick attempt. Anyway, this reduces the number of methods as follows:EDIT: My original idea turned out to be nonsense. But I realized that the solve methods fail when the input matrix happens to be of non-float eltype. Probably rarely occurs, but also doesn't hurt to generalize.