julia_init.c: Use JULIA_DEPOT_PATH and JULIA_LOAD_PATH from the environment
#1032
Conversation
DilumAluthge
changed the title
JULIA_DEPOT_PATH and JULIA_LOAD_PATH from the environmentjulia_init.c: Use JULIA_DEPOT_PATH and JULIA_LOAD_PATH from the environment
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1032 +/- ##
=======================================
Coverage 86.16% 86.16%
=======================================
Files 3 3
Lines 795 795
=======================================
Hits 685 685
Misses 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The CI failure on |
|
Bump. Can this be reviewed please? @KristofferC? Someone else? |
src/julia_init.c
Outdated
| char *new_depot_path = calloc(sizeof (char), new_depot_path_len); | ||
| if (curr_depot_path_len > 0) { | ||
| strcat(new_depot_path, curr_depot_path); | ||
| strcat(new_depot_path, ":"); |
There was a problem hiding this comment.
This should be ; on Windows I think?
There was a problem hiding this comment.
Good catch, thanks!
|
Not to be a pain, but always nice with a test to make sure the intended use case doesn't break in the future.. |
You're absolutely right. Will add one. |
|
BTW, looks like the CI workflow needs updating. All of CI has failed because:
|
When these environment variables are set, use them.
kpamnany
force-pushed
the
kp-fix-depot-path
branch
from
dfcb92f to
e29f517
Compare
When these environment variables are set, use them.
Closes #910.