make sure 1 thread is used in julia processes #1041
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1041 +/- ##
=======================================
Coverage 86.16% 86.16%
=======================================
Files 3 3
Lines 795 795
=======================================
Hits 685 685
Misses 110 110 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This was referenced Apr 21, 2025
PatrickHaecker
suggested changes
Apr 22, 2025
| cmd = `$(get_julia_cmd()) --cpu-target $cpu_target | ||
| cmd = `$(get_julia_cmd()) --threads=1 --cpu-target $cpu_target |
There was a problem hiding this comment.
This is unnecessary (see #1042)
| cmd = addenv(`$(get_julia_cmd()) --cpu-target $cpu_target | ||
| cmd = addenv(`$(get_julia_cmd()) --threads=1 --cpu-target $cpu_target |
There was a problem hiding this comment.
This is unnecessary (see #1042)
| cmd = `$(get_julia_cmd()) --cpu-target=$cpu_target $sysimage_build_args | ||
| cmd = `$(get_julia_cmd()) --threads=1 --cpu-target=$cpu_target $sysimage_build_args |
There was a problem hiding this comment.
This fix is incomplete. If --threads=… or -t=… is set in sysimage_build_args it will override --threads=1, triggering the bug again.
|
I also vote for #1042 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref, https://discourse.julialang.org/t/packagecompiler-hangs-while-compiling-nonincremental-system-image-on-julia-v1-11/128099/14