-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use jldoctest
wherever possible
#56921
Comments
can i work on this issue? |
Of course, you can always contribute when the issue remains open. I would recommend that a pr contain a small number of changes so that it's easy to review. |
hey i just want to ask that to replace all the |
You don't need to replace them manually, but there may be many cases where you need to update the REPL output. I recommend running doctest after the automatic replacement to check that the output matches. Another suggestion is to have a PR that contains only a few changes to make it easier to review. |
PR: #57100 |
@inkydragon I was browsing through the Julia project and came across this issue. Has it been resolved? And if not, could I take a look at trying to reolve it? |
The issue is still open and you can always contribute, just open a PR. |
Hello Sir, I have been working on this issue, and submitted a PR regarding the changes in collection,md file in doc/src/base, but i don't know why the buildkite/julia-master is failing for 5-6 times. Can u please guide me for this issue. I genuinely wanted to work on this issue. |
We can talk about that on the PR you opened :) |
Hi, I wrote this PR for this task: #57840 It doesn't get all of the In general, Edit: I have a similar issue as previous poster, multiple checks fail including buildkite/julia-master. Not sure why that'd be. |
I don't think it's a good idea to change this, although I am new. The doctests are failing because the answers are randomized and so aren't exactly the same as the written answer of what it should be, even though the written answer is also randomized. |
Please use the thread associated with that PR to discuss it. |
jldoctest
didn't used to support repl mode so we have a bunch of code blocks withjulia-repl
tags that should really bejldoctest
instead.Or, if you're feeling ambitious, it would be nice to audit all code blocks (grep for
```
) and make as many as possiblejldoctest
.Advice for folks implementing this
The text was updated successfully, but these errors were encountered: