Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed basedocs.jl and logging.jl to only use jldoctest #57840

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

persinammon4
Copy link

#56921

Small update of two files (logging.jl and basedocs.jl) to switch from julia-repl tag to jldoctest tags.

Would prefer for reviewer to double check that make -C doc doctest=true works for them

@LilithHafner
Copy link
Member

You can look at the doctest failures (in the check job) to see where this still needs work. It's safe for you to ignore all the other CI checks for this PR.

Take a look at https://documenter.juliadocs.org/stable/man/doctests/#Filtering-Doctests for how to handle those undef examples.

@LilithHafner
Copy link
Member

I'd use a filter that only filters out floating point values, not the whole output. e.g. -?\d+\.\d+(e-?\d+)?|NaN|Inf|-Inf

@persinammon4
Copy link
Author

Hi @LilithHafner, so zero regex works, but even the basic regex with or without being raw string is throwing an error for me.

Currently, I'm at this error: LoadError("sysimg.jl", 5, LoadError("Base.jl", 279, LoadError("docs/basedocs.jl", 4, LoadError("docs/basedocs.jl", 2898, ErrorException("parsing command jldoctest; filter = r\"(-?\\s*-?\\d\\.\\d+e[+-]?\\d+\\n)+|NaN|Inf|-Inf\"\njulia> Vector{Float64}(undef, 3)\n3-element Vector{Float64}:\n 6.90966e-310\n 6.90966e-310\n 6.90966e-310\n: special characters \"#{}()[]<>|&*?~;\" must be quoted in commands"))))) for this line of code

jldoctest; filter = "-?\\d+\\.\\d+(e-?\\d+)?\\|NaN\\|Inf\\|-Inf".

Have you experienced this error before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants