Fix issue #11281. #11396
Merged
Fix issue #11281. #11396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be ok to make it a |
blakejohnson
force-pushed
the
brj/fix-tilde-expansion-error
branch
from
12e4464 to
39e83f7
Compare
|
As for making a test, do we have write access to |
Yeah, otherwise packages would all have to be setting custom locations |
|
Changes Unknown when pulling 09cd655 on brj/fix-tilde-expansion-error into ** on master**. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not address the issue raised in #11281 of the regular expression
r"^~(?:/|$)"not being windows-compatible for directory expansion. However, tilde expansion is not normally supported on windows consoles, and ourexpandusermethod is effectively a no-op there. So, I am tempted to mark this regex block as@unix_only.