Add test for Issue #15924 #17989
Closed
Add test for Issue #15924 #17989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@code_lowered didn't show any code. Fixed by JuliaLang#15947
tkelman
added
test
| a = @code_lowered sin(1.0) | ||
| @test isa(a, LambdaInfo) | ||
| b = Base.uncompressed_ast(a) | ||
| @test length(b) == 4 |
There was a problem hiding this comment.
I don't think we should test this. There's no reason this IR has to have length 4; it could easily change due to small changes in the compiler or implementation of the function.
There was a problem hiding this comment.
Also this is covered by the tests immediately above this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@code_lowered didn't show any code (issue #15924). Fixed by #15947.