remove subtypes search for concrete types
#19964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents an unnecessary/expensive call to `_subtypes` when `subtypes` is called on a concrete type.
pabloferz
reviewed
Jan 10, 2017
| @@ -301,7 +301,7 @@ function _subtypes(m::Module, x::DataType, sts=Set{DataType}(), visited=Set{Modu | |||
| end | |||
| return sts | |||
| end | |||
| subtypes(m::Module, x::DataType) = sort(collect(_subtypes(m, x)), by=string) | |||
| subtypes(m::Module, x::DataType) = x.abstract ? sort(collect(_subtypes(m, x)), by=string) : DataType[] | |||
There was a problem hiding this comment.
Maybe we can use the opportunity to also improve this by changing it to sort!(collect(...))
9 tasks
|
Bump, is there any chance this could go into 0.6? We kind of need it for our LanguageServer.jl project, which is the VS Code julia extension. @JeffBezanson, it looks like you might have to review this? |
|
Perhaps add a few tests for |
|
Do you mean a simple: |
|
Yeah, just to hit that code path. |
|
Cool, done |
KristofferC
approved these changes
Jan 26, 2017
|
Can this be merged? |
|
I plan to merge this in a day or so unless I hear anything else. |
|
LGTM. This will conflict with #20307 but it should be easy to resolve. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents an unnecessary/expensive call to
_subtypeswhensubtypesis called on a concrete type.