[release-0.6] Backport fix of #22355 #24484
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infers a missing method (MethodError) as returning `Union{}`
and fix tests that were wrong, but not detected previously!
|
According to @vtjnash this can't be backported. Maybe Jameson can post here explaining why, but in the meantime I'm going to close this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found out in this comment, backporting the commit of this PR fixes the issue #22355
The issue can be easily reproduced with the method explained in this comment.
I checked the latest version of the release-0.6 branch and the issue was still present.
When applying the commit of this PR, it disappears.