Replace all use of 'indexes' with 'indices'#25088
Merged
Merged
Conversation
ararslan
added
breaking
Sacha0
approved these changes
Dec 15, 2017
Member
Sacha0
left a comment
Sacha0
left a comment
There was a problem hiding this comment.
Superficially lgtm! :)
(I lack a strong opinion about these replacements generally.)
ararslan
force-pushed
the
aa/indices-everywhere
branch
from
cf07c4c to
2a776d2
Compare
ararslan
force-pushed
the
aa/indices-everywhere
branch
from
2a776d2 to
c506e2b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes all use of "indexes" as a noun to "indices," which is the proper pluralization of "index." Functions which use
indexesas part of the name, e.g.parentindexesandlocalindexes, have been deprecated accordingly. The only possibly breaking change here is that field names that useindexeshave been changed, so code that specifically tries to access such a field will break without a deprecation.Fixes #12902.