Allow replacement of jl_typeinf_func #31444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 23, 2019
|
I think I'd like to keep the existing API, but I agree it should skip doing extra work if |
timholy
force-pushed
the
teh/replace_inference
branch
from
d21736d to
7d7b2dd
Compare
|
Seems reasonable. Done. |
timholy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #31429. Chances are you don't want to invalidate the entire compile cache, so direct access via
cglobalseems like the most sensible option. Thejl_typeinf_worldexport doesn't seem strictly necessary, but I include it here for symmetry.