Remove eltype check in adjtrans #40567
Conversation
| @propagate_inbounds getindex(v::AdjOrTransAbsVec, i::Int) = wrapperop(v)(v.parent[i-1+first(axes(v.parent)[1])]) | ||
| @propagate_inbounds getindex(A::AdjOrTransAbsMat, i::Int, j::Int) = wrapperop(A)(A.parent[j, i]) | ||
| @propagate_inbounds getindex(v::AdjOrTransAbsVec{T}, i::Int) where {T} = wrapperop(v)(v.parent[i-1+first(axes(v.parent)[1])])::T | ||
| @propagate_inbounds getindex(A::AdjOrTransAbsMat{T}, i::Int, j::Int) where {T} = wrapperop(A)(A.parent[j, i])::T |
There was a problem hiding this comment.
Should this also apply to the getindex methods on the next line?
|
@andyferris Do you still have an opinion on this? It's been a while. |
|
@dkarrasch for the co-authorship, you do it when you commit / rebase: https://docs.github.com/en/github/committing-changes-to-your-project/creating-a-commit-with-multiple-authors |
That helped me in another rebase PR. The next issue is that I can't find @andyferris's e-mail address. |
|
I found this a while ago, which usually works pretty well: https://www.sourcecon.com/how-to-find-almost-any-github-users-email-address/. I added the address to the PR description, so you should just need to squash merge. There really should be some official interface for this though... |
Co-authored-by: Andy Ferris <[email protected]>
dkarrasch
force-pushed
the
dk/simpler_adjtrans
branch
from
54fd671 to
2a45741
Compare
|
Should we merge this? @Sacha0 any follow-up thoughts? |
|
Thanks @dkarrasch |
Co-authored-by: Andy Ferris <[email protected]> Co-authored-by: Andy Ferris <[email protected]>
Co-authored-by: Andy Ferris <[email protected]> Co-authored-by: Andy Ferris <[email protected]>
Co-authored-by: Andy Ferris <[email protected]> Co-authored-by: Andy Ferris <[email protected]>
This is a manual "rebase" of #25274. It removes the eltype checks at construction, which leaves users who call the constructor directly with more responsibility of providing correct eltype.
Closes #25274.
Not sure how to correctly assign authorship here:
Co-authored-by: Andy Ferris [email protected]