wip: scratch compiler plugin #44950
Draft
wip: scratch compiler plugin #44950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is needed to make progress on this PR? |
MasonProtter
reviewed
May 7, 2023
|
|
||
| # TODO more composable way | ||
| global PLUGIN_INTERPRETER::AbstractInterpreter = NativeInterpreter() | ||
| isplugin(interp::AbstractInterpreter) = let |
There was a problem hiding this comment.
Couldn't we just write
isplugin(interp::AbstractInterpreter) = falseand then when someone writes a plugin, they add an overload
CC.isplugin(interp::MyInterpreter) = trueI tested this locally and it appears to work.
There was a problem hiding this comment.
Ah I see the problem, this doesn't work with your way of dealing with dynamic dispatch. Is that the background for #46220 then?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to prototype a minimum compiler plugin system on top of #44197: