REPL: know when to release the prefix context when completing

[IanButterworth]

Fixes #55518

[fingolfin]

This may be obvious, apologies, but does it also work in e.g Foo.Bar.@macro?

[IanButterworth]

Good question, and yeah


Tests added

[IanButterworth]

@aviatesk while this appears to work, one worry I have with this is that this fix should somehow be earlier in the completion handling.

Like, Foo.function(myvar already knows that myvar isn't fixed to the Foo scope before this PR, and that appears to be handled elsewhere.
So maybe detection that we're in macro args space needs to be earlier?

[giordano]

Thanks for looking into this! However examples at #55518 (comment) and #55518 (comment) are still broken:

% julia +pr56322 -q
julia> module Issue55518
       macro name(expr) :($(esc(expr))) end
       const not_really_what_I_wanted = something
       f(; x) = x
       end
Main.Issue55518

julia> using .Issue55518

julia> Issue55518.f(; x=<TAB>

@name
eval
f
include
not_really_what_I_wanted

julia> Issue55518.f; not<TAB>

[IanButterworth]

I feel like REPLCompletions needs to be refactored around JuliaSyntax. There's too much string comparison and regex.

[IanButterworth]

@aviatesk #54858 feels quite breaking, unfortunately. Evidently there just weren't enough tests.

In the context of Mose's examples

julia> Issue55518.f(; x=<TAB>

julia> Issue55518.f; not<TAB>

I don't even know how to approach fixing this, given how REPLCompletions is structured.

I'm going to have to defer to you @aviatesk

[IanButterworth]

Superseded by #57767