Profile: Fix short names #56627
Merged
Profile: Fix short names #56627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/profile_fixes
branch
from
e620c43 to
3f90bba
Compare
|
LGTM. Also I realize I was wrong in my comment that this might be broken on releases. It should be fine since the paths are stored during build time. |
IanButterworth
force-pushed
the
ib/profile_fixes
branch
from
0c8b5d8 to
17ed858
Compare
IanButterworth
force-pushed
the
ib/profile_fixes
branch
from
17ed858 to
982f9dc
Compare
vtjnash
reviewed
Mar 17, 2025
| Profile.print(ioc, C=true) | ||
| str = String(take!(io)) | ||
| slash = Sys.iswindows() ? "\\" : "/" | ||
| @test occursin("@Compiler" * slash, str) |
There was a problem hiding this comment.
These tests have been seen failing quite frequently in CI since merging. Is there something wrong with the PR or test design?
There was a problem hiding this comment.
Somehow the profiler sometimes misses all of the compilation. Perhaps peakflops could be replaced with something like putting a sleep in a generated function eval. Or just test the underlying functions more precisely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression in #56601
Fixes another bug when the Project.toml is bad.
Adds tests.