Add Base.@acquire for non-closure version of Base.acquire(f, s::Base.Semaphore)
#56845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IanButterworth
force-pushed
the
ib/acquire_macro
branch
from
9680219 to
9ab4266
Compare
IanButterworth
commented
Dec 16, 2024
quinnj
approved these changes
Dec 16, 2024
nsajko
added
multithreading
|
Is this purely intended as a workaround for #15276 in the context of usage of If so, IMO it's redundant with the more general workaround of adding a |
ararslan
reviewed
Dec 16, 2024
|
@nsajko I think you'll see from your work that there is a benefit to avoiding closures where possible. |
IanButterworth
added
the
merge me
IanButterworth
commented
Mar 31, 2025
Co-Authored-By: Alex Arslan <[email protected]>
IanButterworth
force-pushed
the
ib/acquire_macro
branch
from
c651112 to
ac7deba
Compare
IanButterworth
changed the title
Base.@acquire for non-closure version of Base.acquire(f, s::Base.Semaphore)Base.@acquire for non-closure version of Base.acquire(f, s::Base.Semaphore)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given
@lockexists, this would make sense.