Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor IOBuffer code #57570

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
+798 −276
Open

Refactor IOBuffer code #57570

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
2e9dcfb
WIP: Comment IOBuffer code
jakobnissen Feb 28, 2025
98bec4e
WIP: Add some more tests
jakobnissen Feb 28, 2025
c4225d4
Update comments after feedback
jakobnissen Feb 28, 2025
75f11af
Remove offset field from GenericIOBuffer
jakobnissen Feb 28, 2025
30b0a64
Refactor resizing
jakobnissen Mar 1, 2025
ea8bf4f
Update comments to mention mark is zero-indexed
jakobnissen Mar 1, 2025
e36abea
Handle maxsize and sizehint better on IOBuffer construction
jakobnissen Mar 1, 2025
9ea4489
Allow read and peek from non-dense IOBuffer
jakobnissen Mar 1, 2025
45f4ca1
Also reinit used-up non-Memory buffer after take!
jakobnissen Mar 1, 2025
8820dd2
Use memcpy to write to IOBuffer when applicable
jakobnissen Mar 1, 2025
5d3d5e8
Simplify and speed-up occursin implementation
jakobnissen Mar 1, 2025
6577e55
Bugfix: Buffer behaviour in unsafe_read
jakobnissen Mar 2, 2025
09a11ea
Add more tests
jakobnissen Mar 2, 2025
caa3375
Bugfix: Fix copyline for non-appending IOBuffer
jakobnissen Mar 2, 2025
cf0a30b
Minor optimisation of write(::IOBuffer, mem)
jakobnissen Mar 3, 2025
e3a9c20
Enforce invariants in IOBuffer constructors
jakobnissen Mar 3, 2025
f0ca5fe
Tweak compacting heuristics
jakobnissen Mar 3, 2025
3673d4e
Bugfix: Copying to self with appending buffer
jakobnissen Mar 3, 2025
0d1c310
Rename Unsafe to UnsafeMethod
jakobnissen Mar 3, 2025
40fe2b3
Fix errors during build
jakobnissen Mar 3, 2025
ab6ccfc
Fix typo in test
jakobnissen Mar 3, 2025
c4f6a05
Skip initializing IOBuffer data
jakobnissen Mar 3, 2025
ccb1db0
Reinstate offset field
jakobnissen Mar 4, 2025
5fbf4e0
Address some reviewer comments
jakobnissen Mar 4, 2025
df1c215
Try to make inferrible for trimming CI
jakobnissen Mar 4, 2025
df029e8
Minor change in comments
jakobnissen Mar 4, 2025
164513e
DECISION: Do not fill buffer past maxsize
jakobnissen Mar 4, 2025
3ce4bce
More efficient copy of IOBuffer
jakobnissen Mar 4, 2025
16ff6ed
Address reviewer comments
jakobnissen Mar 11, 2025
52f60cd
Fixup
jakobnissen Mar 11, 2025
840c3de
WIP: Address some reviewer comments
jakobnissen Mar 21, 2025
fcc83c1
Error when calling `write(x::IOBuffer, x)`
jakobnissen Mar 21, 2025
b341967
Make writing between IOBuffer always exhaust the source
jakobnissen Mar 21, 2025
57a82a6
Address some more reviewer comments
jakobnissen Mar 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading