Compute has_concrete_subtype after field types
#57764
Open
+84
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serenity4
commented
Mar 13, 2025
serenity4
commented
Mar 13, 2025
serenity4
commented
Mar 13, 2025
|
Tests seem to be passing, this is good for review. |
added 5 commits
March 18, 2025 11:53
|
@vtjnash would you be keen to suggest a reviewer, or perhaps even assign yourself, for this PR? |
vtjnash
reviewed
Mar 21, 2025
vtjnash
reviewed
Mar 21, 2025
vtjnash
reviewed
Mar 21, 2025
added 6 commits
March 24, 2025 09:27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57673 (comment), allowing
valid_as_latticeto correctly returnfalsewhen provided with aUnionAlltype that contains a field parametrized with aUnion{}type parameter. This should in most cases prevent inference from using such types that are invalid at runtime.