Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring codegen passes that lower write barrier and allocation #57769

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

udesou
Copy link
Contributor

@udesou udesou commented Mar 14, 2025

Moving the lowering functions that are GC-specific (allocation and write barriers) into the final lowering pass.

@udesou
Copy link
Contributor Author

udesou commented Mar 14, 2025

@vchuravy This draft is an attempt to separate the lowering functions for write barriers and allocation as we discussed on slack. It's still a draft because I'd appreciate your feedback on whether this is the right way to do it. I think one of the tests in llvmpasses is failing so I still need to look into it.
I might also do minor changes to the code but if you think I should do something differently, please let me know.
I have also included the lowering code for MMTk's barrier, for your reference - but that will only be fully working once we support sticky Immix (#57327).

@udesou udesou force-pushed the refactor/codegen-gc-specific-passes branch from e77c057 to b5d84e8 Compare March 14, 2025 02:23
@udesou udesou requested a review from vchuravy March 14, 2025 02:23
@udesou udesou added GC Garbage collector GC: MMTK MMTK GC integration labels Mar 14, 2025
@vchuravy
Copy link
Member

(I am on vacation until April, please ping me then)

@udesou udesou force-pushed the refactor/codegen-gc-specific-passes branch 5 times, most recently from e826c88 to 6c937c0 Compare March 17, 2025 03:57
@udesou udesou requested a review from gbaraldi March 18, 2025 22:08
@udesou udesou force-pushed the refactor/codegen-gc-specific-passes branch from 6c937c0 to 1a1b2b9 Compare March 18, 2025 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GC: MMTK MMTK GC integration GC Garbage collector
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants