Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated collections.md from julia to jldoctest #56921 #57796

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vivekTiw120303
Copy link

Changed the julia blocks to jldoctest in collection.md in julia/doc/src/base with proper output

@LilithHafner
Copy link
Member

@vivekTiw120303, please stop opening and abandoning PRs address this. Doing that fragments conversation. You can continue with a single PR.

cross ref: #57595, #57619, #57786

@LilithHafner
Copy link
Member

The build and doctest CI jobs pass which are the most relevant to this PR. Our CI fails most of the time due to flakeyness. Right now the upload jobs tend to fail so it's okay that they fail on this PR. You can check CI details by clicking on the checks and you can see what checks you can expect to fail by checking the CI failures on master.

@LilithHafner
Copy link
Member

The changes in this PR (converting a script to a REPL session) make the documentation harder to read in my opinion. I recommend starting by replacing a single occurrence of julia-repl with jldoctest in a way that doesn't change the rendered output.

@LilithHafner LilithHafner added the docs This change adds or pertains to documentation label Mar 16, 2025
@vivekTiw120303
Copy link
Author

Ok Sir, thankyou for your guidance, will note all the points above and will work towards it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs This change adds or pertains to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants