libunwind: Link against Julia zlib #57798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we don't add `$(build_shlibdir)` to the search path, currently unwind seems to link against the system zlib. As mentioned in libunwind/libunwind#653 and from `configure --help` the standard way to link against a library in a non standard location is to set the `CPPFLAGS` and `LDFLAGS`. Tested by building with nix and in the package_linux rootfs image where we don't install zlib (though the shared library happens to be in the search path, the headers aren't). Fixes JuliaLang#55617.
Zentrik
added
building
giordano
reviewed
Mar 17, 2025
| LIBUNWIND_CPPFLAGS := | ||
| LIBUNWIND_CFLAGS := -U_FORTIFY_SOURCE $(fPIC) $(SANITIZE_OPTS) | ||
| LIBUNWIND_CPPFLAGS := -I$(build_includedir) | ||
| LIBUNWIND_LDFLAGS := -L$(build_shlibdir) |
There was a problem hiding this comment.
To be clear, we don't need to pass -lz here? The library would be picked up automatically?
There was a problem hiding this comment.
Yep, and the configure will error if it doesn't find zlib as we pass a flag enabling zlib support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we don't add
$(build_shlibdir)to the search path, currently unwind seems to link against the system zlib. As mentioned in libunwind/libunwind#653 and fromconfigure --helpthe standard way to link against a library in a non standard location is to set theCPPFLAGSandLDFLAGS. Tested by building with nix and in the package_linux rootfs image where we don't install zlib (though the shared library happens to be in the search path, the headers aren't).Fixes #55617.