Fix #55820 : missing _convert_rounding methods for RoundFromZero #57802
+22
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Zero
- Implemented `_convert_rounding` method for `RoundingMode{:FromZero}`
to handle conversions to `AbstractFloat`.
- Supported conversions for the following floating-point types:
- Float16, Float32, Float64, AbstractFloat, BigFloat
- Handled real number types including:
- Bool, Rational{Int8}
- Added tests to validate conversions for all affected type
combinations.
Renamed test to better reflect its purpose and included the issue number for easier tracking. Co-authored-by: Lilith Orion Hafner <[email protected]>
- Improve test coverage beyond zero-to-zero cases - Include tests for large positive and negative values - Ensure correct rounding behavior for nextfloat(0.0) Co-authored-by: Lilith Orion Hafner <[email protected]>
|
Hey @LilithHafner, I've tested and committed the suggested tests. Let me know if there's anything else to adjust. Thanks for the review. |
|
Thanks! Please also remove as many deviations from the |
|
While you are welcome to use AI to assist you in learning or explaining things to you, it is not acceptable to post AI generated content under your own name or otherwise under the guise of human content. |
|
I'm sincerely sorry, I’ve deleted the comment and I won’t use AI for writing assistance anymore. It was mainly for grammar correction. The code and tests are entirely my own, would it still be okay to proceed with the commit? |
|
No, we can't proceed with merging until you address #57802 (comment) and #57802 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_convert_roundingmethod forRoundingMode{:FromZero}to handle conversions toAbstractFloat.