Fix #37756: Correct formatting of hexadecimal imaginary parts #57803
+16
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 'show' method for 'Complex' was not properly handling cases where
the imaginary part was represented in hexadecimal ('0x'). This could
lead to missing multiplication symbols '*' in the output, making the
formatting inconsistent.
To fix this, a check using 'occursin("0x", repr(i))' was added to
detect these cases and ensure proper formatting.
This improves the consistency of complex number representations and
prevents ambiguities in the printed output.
LilithHafner
added
needs tests
Replaced explicit conditionals with a type check to make the code easier to understand and maintain. This ensures that the logic is clearer while preserving the original behavior. Co-authored-by: Lilith Orion Hafner <[email protected]>
These additions improve test coverage and ensure robust handling of different numeric representations in the `show` function. This extends the test suite in reference to issue JuliaLang#37756.
Co-authored-by: Lilith Orion Hafner <[email protected]>
|
Hey @LilithHafner, I have applied the suggested changes. |
LilithHafner
approved these changes
Mar 17, 2025
JeffBezanson
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'show' method for 'Complex' was not properly handling cases where the imaginary part was represented in hexadecimal ('0x'). This could lead to missing multiplication symbols '*' in the output, making the formatting inconsistent.
To fix this, a check using 'occursin("0x", repr(i))' was added to detect these cases and ensure proper formatting.
This improves the consistency of complex number representations and prevents ambiguities in the printed output.